Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genai: add explicit MIME type CreateCachedContent example #199

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

jba
Copy link
Collaborator

@jba jba commented Jul 26, 2024

The model seems to require it (even though it correctly infers
that the MIME type is text/plain).

Fixes #198.

@jba jba requested a review from eliben July 26, 2024 12:54
Copy link
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated now. You should modify genai/internal/samples/docs-snippets_test.go and then go generate

Also #189 is related and should land, I was waiting for @fredsa review, but I'll ask you to review it now so we could update the comment

The model seems to require it (even though it correctly infers
that the MIME type is text/plain).
@jba jba force-pushed the jba/fix-example branch from 4506a7d to 9f5281e Compare July 26, 2024 13:18
@jba
Copy link
Collaborator Author

jba commented Jul 26, 2024

Done.

@jba jba requested a review from eliben July 26, 2024 13:20
@jba jba merged commit 2bfb559 into main Jul 26, 2024
2 checks passed
@jba jba deleted the jba/fix-example branch July 26, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants